-
Notifications
You must be signed in to change notification settings - Fork 95
docs: add known ipred-ctrl issue for speicfic cpu model #959
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds documentation for a known upgrade issue related to the cpu-feature.node.kubevirt.io/ipred-ctrl=true CPU feature that appears during upgrades from v1.5.x to v1.6.x on specific Intel Xeon CPU models. The documentation provides workarounds for users before and after the upgrade.
Changes:
- Added a new section (§8) documenting the ipred-ctrl CPU feature issue during upgrades
- Updated subsequent section numbering (previous §8 becomes §9)
- Provided specific CPU models affected and multiple resolution options
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| docs/upgrade/v1-5-x-to-v1-6-x.md | Added new section 8 documenting ipred-ctrl CPU feature issue and renumbered subsequent sections |
| versioned_docs/version-v1.6/upgrade/v1-5-x-to-v1-6-x.md | Added identical documentation for v1.6 versioned docs |
| versioned_docs/version-v1.7/upgrade/v1-5-x-to-v1-6-x.md | Added identical documentation for v1.7 versioned docs |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
77dc1a7 to
22c4a22
Compare
docs/upgrade/v1-5-x-to-v1-6-x.md
Outdated
| **After the upgrade:** | ||
| - Reboot the virtual machines. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if node-labeller was disabled, then VM's do not need to rebooted after the upgrade as selector labels matching cpu features will not have changed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you're right, done!
jillian-maroket
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review done
Signed-off-by: Jack Yu <jack.yu@suse.com>
Co-authored-by: Gaurav Mehta <gaurav.mehta@suse.com> Signed-off-by: Jack Yu <jack.yu@suse.com>
Signed-off-by: Jack Yu <jack.yu@suse.com>
Co-authored-by: Jillian Maroket <67180770+jillian-maroket@users.noreply.github.com> Signed-off-by: Jack Yu <jack.yu@suse.com>
Co-authored-by: Jillian Maroket <67180770+jillian-maroket@users.noreply.github.com> Signed-off-by: Jack Yu <jack.yu@suse.com>
Co-authored-by: Jillian Maroket <67180770+jillian-maroket@users.noreply.github.com> Signed-off-by: Jack Yu <jack.yu@suse.com>
Signed-off-by: Jack Yu <jack.yu@suse.com>
74c7c0a to
24a36c8
Compare
Problem:
Solution:
Related Issue(s):
Test plan:
Additional documentation or context